Find StyleSheet declarations that are not variables #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! If you resolve the conflicts I think we can merge |
draperunner
force-pushed
the
sort-styles-default-export
branch
from
d6cc5d1 to
875c030
Compare
draperunner
force-pushed
the
sort-styles-default-export
branch
from
875c030 to
8921b20
Compare
|
@Intellicode I have fixed the merge conflicts. |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214
Instead of only looking for
StyleSheetdeclarations inVariableDeclaratornodes, we check ifCallExpressionsareStyleSheet.create({...}). This handles theexport default StyleSheet.create({...})case and other cases where the style sheet is not assigned to a variable.